-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Add support for arbitrary service attributes - Option #1 #3415
Merged
markwallace-microsoft
merged 31 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/adr-aiservice-metadata
Nov 13, 2023
Merged
.Net: Add support for arbitrary service attributes - Option #1 #3415
markwallace-microsoft
merged 31 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/adr-aiservice-metadata
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dr-aiservice-metadata
…ng the service metadata
…dr-aiservice-metadata
shawncal
added
docs and tests
Improvements or additions to documentation
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
kernel.core
memory connector
labels
Nov 7, 2023
github-actions
bot
changed the title
Users/markwallace/adr aiservice metadata
.Net: Users/markwallace/adr aiservice metadata
Nov 7, 2023
…dr-aiservice-metadata
markwallace-microsoft
changed the title
.Net: Users/markwallace/adr aiservice metadata
.Net: Add support for arbitrary service attributes - Option #1
Nov 8, 2023
markwallace-microsoft
changed the title
.Net: Add support for arbitrary service attributes - Option #1
.Net: Add support for arbitrary service attributes - Option #1 (Dictionary<string, object>)
Nov 8, 2023
…thub.com/markwallace-microsoft/semantic-kernel into users/markwallace/adr-aiservice-metadata
markwallace-microsoft
changed the title
.Net: Add support for arbitrary service attributes - Option #1 (Dictionary<string, object>)
.Net: Add support for arbitrary service attributes - Option #1
Nov 10, 2023
dotnet/src/SemanticKernel.UnitTests/Functions/OrderedIAIServiceConfigurationProviderTests.cs
Show resolved
Hide resolved
RogerBarreto
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SergeyMenshykh
approved these changes
Nov 13, 2023
markwallace-microsoft
deleted the
users/markwallace/adr-aiservice-metadata
branch
November 13, 2023 11:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs and tests
Improvements or additions to documentation
kernel
Issues or pull requests impacting the core kernel
memory connector
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist