Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Add support for arbitrary service attributes - Option #1 #3415

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@shawncal shawncal added docs and tests Improvements or additions to documentation .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core memory connector labels Nov 7, 2023
@github-actions github-actions bot changed the title Users/markwallace/adr aiservice metadata .Net: Users/markwallace/adr aiservice metadata Nov 7, 2023
@markwallace-microsoft markwallace-microsoft changed the title .Net: Users/markwallace/adr aiservice metadata .Net: Add support for arbitrary service attributes - Option #1 Nov 8, 2023
@markwallace-microsoft markwallace-microsoft changed the title .Net: Add support for arbitrary service attributes - Option #1 .Net: Add support for arbitrary service attributes - Option #1 (Dictionary<string, object>) Nov 8, 2023
@markwallace-microsoft markwallace-microsoft marked this pull request as ready for review November 10, 2023 19:01
@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner November 10, 2023 19:01
@markwallace-microsoft markwallace-microsoft changed the title .Net: Add support for arbitrary service attributes - Option #1 (Dictionary<string, object>) .Net: Add support for arbitrary service attributes - Option #1 Nov 10, 2023
Copy link
Member

@RogerBarreto RogerBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Nov 13, 2023
Merged via the queue into microsoft:main with commit 5e5b4a4 Nov 13, 2023
18 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/adr-aiservice-metadata branch November 13, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel memory connector .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants