Python: pysdk issue 3897 - update notebooks #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
LGTM. Thank you for doing this. There is one conflict we'll need to resolve: we had to update the pyproject.toml version to 0.4.2 yesterday for a release. Once this is resolved, feel free to convert from a draft to a PR. Thanks! |
added 17 commits
December 13, 2023 11:17
1. use keyword arguments 2. set my own deployment name for Azure OpenAI 3. update chat message
1. use latest version of sk 2. use keyword argument 3. set own deployment name 4. update message
1. install SK 2. remove unused cell 3. remove unused statements 4. use keyword arguments
1. use latest version of sk 2. remove unused import 3. remove duplicate sk init cell 4. change the default value & input value from int to str 5. use keyword arguments
1. Increase version number of the SDK 2. Update the default value of `TextMemorySkill` from int/float to str 3. Use keyword arguments
1. Use the latest version of sdk 2. Use keyword arguments
1. Use latest version of SDK 2. Use keyword arguments
1. Use the latest version of SDK 2. Use keyword arguments
1. Use latest version 2. Use keyword arguments
1. Use the latest SDK 2. Use keyword arguments
1. Use latest version of the SDK 2. Use keyword arguments
1. Use latest sdk 2. Use keyword arguments
rewrlution
force-pushed
the
pysdk-issue-3897
branch
from
221a929
to
915495e
Compare
I have resolved the conflict and rebased the branch. |
moonbox3
approved these changes
Dec 13, 2023
zengin
pushed a commit
to microsoftgraph/semantic-kernel
that referenced
this pull request
Jan 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> microsoft#3897 In this PR, I updated the notebooks to use the latest version of the python SDK. To make the notebooks work, I need to: 1. Use keyword arguments 2. Change the default value in the `ContextVariables` from `int/float` to `str` 3. Update `TextMemorySkill` 4. Update some inputs, such as `ChatMessage` I have noted some inconsistency issues in the microsoft#3897 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 馃槃 --------- Co-authored-by: Huijing Huang <huijinghuang@microsoft.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
#3897
In this PR, I updated the notebooks to use the latest version of the python SDK.
To make the notebooks work, I need to:
ContextVariablesfromint/floattostrTextMemorySkillChatMessageI have noted some inconsistency issues in the #3897
Contribution Checklist