Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Mark gRPC and OpenAPI Functions as Experimental #4244

Merged
merged 4 commits into from
Dec 13, 2023
Merged

.Net: Mark gRPC and OpenAPI Functions as Experimental #4244

merged 4 commits into from
Dec 13, 2023

Conversation

SergeyMenshykh
Copy link
Member

@SergeyMenshykh SergeyMenshykh commented Dec 13, 2023 •
edited

Related issue - #4223

  • Mark gRPC and OpenAPI functions as experimental, to improve them in v1.
  • Enable dynamic payload building by default, aligning with the functionality of other functions.

@SergeyMenshykh
1. Grpc and OpenApi funcitons are marked as experimental
aa9edf3 
2. Dynamic payload bulding is enabled by default.
@SergeyMenshykh SergeyMenshykh requested a review from a team as a code owner December 13, 2023 19:29
@shawncal shawncal added docs and tests Improvements or additions to documentation .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Dec 13, 2023
@SergeyMenshykh SergeyMenshykh added the v1.0.1 Required for the Semantic Kernel v1.0.1 release label Dec 13, 2023
RogerBarreto
RogerBarreto approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@RogerBarreto RogerBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comments

dotnet/src/Functions/Functions.UnitTests/Functions.UnitTests.csproj Outdated Show resolved Hide resolved
dotnet/src/IntegrationTests/IntegrationTests.csproj Outdated Show resolved Hide resolved
SergeyMenshykh and others added 2 commits December 13, 2023 19:49
@SergeyMenshykh @RogerBarreto
Update dotnet/src/Functions/Functions.UnitTests/Functions.UnitTests.c…
d01f5d5 
…sproj

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
@SergeyMenshykh @RogerBarreto
Update dotnet/src/IntegrationTests/IntegrationTests.csproj
f7ae937 
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Dec 13, 2023
Merged via the queue into microsoft:main with commit 29f72ac Dec 13, 2023
18 checks passed
@SergeyMenshykh SergeyMenshykh deleted the openapi-createpayload-by-default branch December 13, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerBarreto RogerBarreto RogerBarreto approved these changes

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

@dmytrostruk dmytrostruk Awaiting requested review from dmytrostruk

Assignees
No one assigned
Labels
docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code v1.0.1 Required for the Semantic Kernel v1.0.1 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SergeyMenshykh @RogerBarreto @markwallace-microsoft @shawncal