.Net: Aligning the SK agent HTTP stack behavior with the SK one #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ClaimrException and RequestFailedException (thrown by AzureSDK) are translated into HttpOperationException. Doing so conceals SK/Agent internal implementation details (whether requests are sent via vanilla HttpClient or third-party client library) from SK/Agent consumer code. Additionally, this will future-proof SK/Agent consumer code, as it will require only one catch block - catch(HttpOperationException ex), which once added, will work regardless of the connector (currently, only OpenAI) used to access LLM.
SergeyMenshykh
requested review from
dmytrostruk,
RogerBarreto,
crickman and
markwallace-microsoft
SergeyMenshykh
added
PR: ready for review
markwallace-microsoft
approved these changes
Jan 11, 2024
crickman
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Aligning the SK agent HTTP stack behavior with the SK one, where HttpClientException and RequestFailedException (thrown by AzureSDK) are translated into HttpOperationException. Doing so hides SK/Agent internal implementation details (whether requests are sent via vanilla HttpClient or third-party client library) from SK/Agent consumer code without losing original exception details. Additionally, this will future-proof the SK/Agent consumer code, as it will require only one catch block - catch(HttpOperationException ex), which once added, will work regardless of the connector (currently, only OpenAI) used to access LLM.
ADR for similar changes in SK - https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0004-error-handling.md