.Net: Extend chat message parsing and add relevant unit tests #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chat message parsing logic in ChatPromptParser.cs has been refactored to boost code readability and modularity. A new method named 'ParseChatNode' for interpreting images and text content within chat messages has been introduced. In addition, Image and Text tag names have been added, and the 'IsValidChatMessage' method has been enhanced to check for validity more effectively. Concurrently, unit tests for ChatPromptParser have been implemented to validate these changes.
shawncal
added
.NET
github-actions
bot
changed the title
4 tasks
Krzysztof318
changed the title
dmytrostruk
reviewed
Jan 15, 2024
There was a problem hiding this comment.
@Krzysztof318 Thank you for your contribution and thanks for adding unit tests for new functionality! I left a couple of small comments.
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatPromptParser.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatPromptParser.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatPromptParser.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatPromptParser.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatPromptParser.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.UnitTests/Prompt/ChatPromptParserTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatPromptParser.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatPromptParser.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Optimized the ChatPromptParser by removing unnecessary null checks and breaking down complex expressions. Specifically, the IsValidChatMessage method was refactored by separating the check for valid child nodes. Test headers were also removed for clarity.
dmytrostruk
approved these changes
Jan 17, 2024
markwallace-microsoft
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Splitted PR #4536
Allow passing image content in prompt text.
Description
Added new method named 'ParseChatNode' for interpreting images and text content within chat messages.
Added unit tests for ChatPromptParser.
Contribution Checklist