Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Renames SK prefix to Kernel #4716

Merged
merged 9 commits into from
Jan 24, 2024
Merged

Python: Renames SK prefix to Kernel #4716

merged 9 commits into from
Jan 24, 2024

Conversation

juliomenendez
Copy link
Contributor

Motivation and Context

The .NET SDK uses the Kernel prefix instead of SK for the context, function, model, etc. classes. This PR aligns the Python package with that policy.

Fixes #4561

Contribution Checklist

@juliomenendez juliomenendez requested a review from a team as a code owner January 23, 2024 21:35
@shawncal shawncal added python Pull requests for the Python Semantic Kernel documentation labels Jan 23, 2024
eavanvalkenburg
eavanvalkenburg approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

moonbox3
moonbox3 approved these changes Jan 24, 2024
View reviewed changes
python/DEV_SETUP.md Outdated Show resolved Hide resolved
@moonbox3 moonbox3 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into microsoft:main with commit 0871037 Jan 24, 2024
26 checks passed
@juliomenendez juliomenendez deleted the juliome/issue-4561-rename-sk-prefix-kernel branch January 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

@moonbox3 moonbox3 moonbox3 approved these changes

Assignees
No one assigned
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: Rename SK prefix to "Kernel"
4 participants
@juliomenendez @eavanvalkenburg @moonbox3 @shawncal