Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Add home automation example to demonstrate how to use DI in a real app #4940

Merged
merged 21 commits into from
Mar 5, 2024

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented Feb 8, 2024

Motivation and Context

We want to give a template or starting point for people to get a solid idea of how to use SK in their own apps.

Description

Add the Home Automation example

Contribution Checklist

@glahaye glahaye requested a review from a team as a code owner February 8, 2024 22:55
@glahaye glahaye marked this pull request as draft February 8, 2024 22:56
@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Feb 8, 2024
@github-actions github-actions bot changed the title Add home automation example to demonstrate how to use DI in a real app .Net: Add home automation example to demonstrate how to use DI in a real app Feb 8, 2024
@glahaye glahaye self-assigned this Feb 8, 2024
Copy link
Member

@matthewbolanos matthewbolanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this come together! Left some comments based on some of the challenges I've seen customers have with DI.

dotnet/samples/HomeAutomation/Program.cs Outdated Show resolved Hide resolved
dotnet/samples/HomeAutomation/Program.cs Outdated Show resolved Hide resolved
dotnet/samples/HomeAutomation/Program.cs Outdated Show resolved Hide resolved
dotnet/samples/HomeAutomation/Program.cs Outdated Show resolved Hide resolved
dotnet/samples/HomeAutomation/Program.cs Outdated Show resolved Hide resolved
dotnet/samples/HomeAutomation/Program.cs Outdated Show resolved Hide resolved
dotnet/samples/HomeAutomation/Program.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@Krzysztof318 Krzysztof318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice have support openai endpoint out-of-box and optional azure. Many of customers doesn't have access the Azure OpenAI.

@matthewbolanos
Copy link
Member

Could we add a .vscode folder with the necessary files so a developer can press the run button to test the sample

@glahaye glahaye enabled auto-merge March 5, 2024 21:08
@glahaye glahaye added this pull request to the merge queue Mar 5, 2024
Merged via the queue into microsoft:main with commit b2d0b99 Mar 5, 2024
18 checks passed
@glahaye glahaye deleted the home_automation_example branch March 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants