.Net: Removing Insufficient functions error #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
teresaqhoang
force-pushed
the
insufficient-functions-error
branch
from
e230d0a
to
b22a90a
Compare
glahaye
approved these changes
Feb 15, 2024
markwallace-microsoft
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR removes the InsufficientFunctions error message. If the planner doesn't have enough context to create a plan, it should forego a template altogether and return an error string. This will be captured by the
InvalidTemplatecheck.Description
Addresses #4442, which identified that this error handling was so restrictive for most plan types.
Contribution Checklist