-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net. ContentFilterResults added to text/message content metadata #5020
Merged
SergeyMenshykh
merged 6 commits into
microsoft:main
from
SergeyMenshykh:content-filter-result-fix
Feb 19, 2024
Merged
.Net. ContentFilterResults added to text/message content metadata #5020
SergeyMenshykh
merged 6 commits into
microsoft:main
from
SergeyMenshykh:content-filter-result-fix
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
approved these changes
Feb 15, 2024
RogerBarreto
approved these changes
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
) ### Motivation and Context Today, the code for populating metadata for message/text content does not add the ContentFilterResults property value from individual choices into the content metadata. Closes #4996 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
…Menshykh/semantic-kernel into content-filter-result-fix
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
RogerBarreto
approved these changes
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Today, the code for populating metadata for message/text content does not add the ContentFilterResults property value from individual choices into the content metadata.
Closes #4996
Contribution Checklist