.Net: Improved Audio API by adding default setting values #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
.NET
dmytrostruk
added
the
PR: ready for review
markwallace-microsoft
approved these changes
Feb 15, 2024
dotnet/src/Connectors/Connectors.OpenAI/AudioToText/OpenAIAudioToTextExecutionSettings.cs
Show resolved
Hide resolved
RogerBarreto
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Current audio interfaces have optional execution settings parameters in order to be able to use audio API through Kernel in the future, where execution settings are optional. But when using audio services directly, this is not user friendly, because when optional execution settings are not configured, services will throw an error.
In case of text-to-audio service, required field is voice. This PR sets default value to
alloywith the ability to overwrite.For audio-to-text service, required field is filename. This PR sets default value to
file.mp3with the ability to overwrite.With these changes execution settings are no longer required (they are optional) for text-to-audio and audio-to-text conversion.
Contribution Checklist