.Net: Add early return if Freeze method is called on a frozen object #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Freeze` method in both `PromptExecutionSettings` and `OpenAIPromptExecutionSettings` classes now include an early return condition. This checks if the instance is already frozen, and if so, the method execution is immediately stopped. This improvement prevents unnecessary computations in these classes' `Freeze` methods.
shawncal
added
.NET
4 tasks
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Feb 17, 2024
RogerBarreto
approved these changes
Feb 19, 2024
stephentoub
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In PromptExecutionSettings is a bug which creates new ReadOnlyCollection even object is already freezed.
Description
The
Freezemethod in bothPromptExecutionSettingsandOpenAIPromptExecutionSettingsclasses now include an early return condition. This checks if the instance is already frozen, and if so, the method execution is immediately stopped. This improvement prevents unnecessary computations in these classes'Freezemethods.Contribution Checklist