Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: fix: qdrant upsert on same id #5090

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

ytoml
Copy link
Contributor

@ytoml ytoml commented Feb 20, 2024

Motivation and Context

This bug prevent us from using QdrantMemoryStore as memory.

Description

Contribution Checklist

@ytoml ytoml requested a review from a team as a code owner February 20, 2024 14:32
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels Feb 20, 2024
@github-actions github-actions bot changed the title fix: qdrant upsert on same id Python: fix: qdrant upsert on same id Feb 20, 2024
@ytoml
Copy link
Contributor Author

ytoml commented Feb 20, 2024

@microsoft-github-policy-service agree

Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding another test.

@ytoml
Copy link
Contributor Author

ytoml commented Mar 7, 2024

I'm waiting for this to be merged...

@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL4850102079% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python Unit Test Overview

Tests Skipped Failures Errors Time
990 11 💤 0 ❌ 0 🔥 16.674s ⏱️

@moonbox3
Copy link
Contributor

moonbox3 commented Mar 7, 2024

I'm waiting for this to be merged...

The PR needs one more approval.

@markwallace-microsoft
Copy link
Member

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL486597480% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1027 11 💤 0 ❌ 0 🔥 21.120s ⏱️

@markwallace-microsoft
Copy link
Member

Py3.9 Test Coverage

Python 3.9 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL500296781% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.9 Unit Test Overview

Tests Skipped Failures Errors Time
1027 2 💤 0 ❌ 0 🔥 17.448s ⏱️

@markwallace-microsoft
Copy link
Member

Py3.11 Test Coverage

Python 3.11 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL500896681% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.11 Unit Test Overview

Tests Skipped Failures Errors Time
1027 1 💤 0 ❌ 0 🔥 18.310s ⏱️

@markwallace-microsoft
Copy link
Member

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL500896681% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1027 1 💤 0 ❌ 0 🔥 18.516s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Mar 7, 2024
Merged via the queue into microsoft:main with commit d956799 Mar 7, 2024
30 checks passed
@ytoml ytoml deleted the fix-qdrant-upsert branch April 5, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants