Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net - Updated Open AI Assistant Model Serialization #5102

Merged
merged 3 commits into from
Feb 21, 2024
Merged

.Net - Updated Open AI Assistant Model Serialization #5102

merged 3 commits into from
Feb 21, 2024

Conversation

crickman
Copy link
Contributor

Motivation and Context

Certain model properties not serializing properly due to definition alignment.

Description

Agent === Assistant when dealing with Open AI models.

Contribution Checklist

@crickman crickman added bug Something isn't working PR: ready for review All feedback addressed, ready for reviews kernel Issues or pull requests impacting the core kernel experimental Associated with an experimental feature agents labels Feb 21, 2024
@crickman crickman self-assigned this Feb 21, 2024
@crickman crickman requested a review from a team as a code owner February 21, 2024 04:40
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code and removed kernel Issues or pull requests impacting the core kernel labels Feb 21, 2024
@crickman crickman added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 1f731ca Feb 21, 2024
18 checks passed
@crickman crickman deleted the fix_assistantmodels branch February 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@glahaye glahaye glahaye approved these changes

@alliscode alliscode alliscode approved these changes

@matthewbolanos matthewbolanos Awaiting requested review from matthewbolanos

@SergeyMenshykh SergeyMenshykh Awaiting requested review from SergeyMenshykh

@markwallace-microsoft markwallace-microsoft Awaiting requested review from markwallace-microsoft

Assignees

@crickman crickman

Labels
agents bug Something isn't working experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crickman @stephentoub @glahaye @alliscode @markwallace-microsoft