Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net AudioContent class moved to the Microsoft.SemanticKernel namespace #5112

Merged

Conversation

SergeyMenshykh
Copy link
Member

The AudioContent class lives in the Microsoft.SemanticKernel.Contents namespace, while the other content classes reside in the Microsoft.SemanticKernel namespace. This PR moves the AudioContent class to the Microsoft.SemanticKernel namespace to align it with the other content classes.

…ce to align it with the other content classes.
@SergeyMenshykh SergeyMenshykh added the .NET Issue or Pull requests regarding .NET code label Feb 21, 2024
@SergeyMenshykh SergeyMenshykh self-assigned this Feb 21, 2024
@SergeyMenshykh SergeyMenshykh requested a review from a team as a code owner February 21, 2024 22:27
@markwallace-microsoft markwallace-microsoft added kernel Issues or pull requests impacting the core kernel kernel.core labels Feb 21, 2024
Copy link
Member

@dmytrostruk dmytrostruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, thanks for fixing this. Pipelines are failing, since it's breaking change. I've added suppression files to proceed with merging.

@SergeyMenshykh
Copy link
Member Author

My mistake, thanks for fixing this. Pipelines are failing, since it's breaking change. I've added suppression files to proceed with merging.

No problem at all. We should have done a better job reviewing the PR. Thanks for adding the suppression.

@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Feb 22, 2024
Merged via the queue into microsoft:main with commit cd463b8 Feb 22, 2024
18 checks passed
@SergeyMenshykh SergeyMenshykh deleted the namespace-for-audio-content branch February 22, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants