Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Python: remove _async from methods #5160

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

david-polo
Copy link
Contributor

Motivation and Context

Fix error #5092.

Description

  • rename methods of AstraMemoryStore

Contribution Checklist

@david-polo david-polo requested a review from a team as a code owner February 26, 2024 16:46
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels Feb 26, 2024
@github-actions github-actions bot changed the title remove _async from methods Python: remove _async from methods Feb 26, 2024
@david-polo david-polo requested a review from a team as a code owner February 26, 2024 18:14
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Feb 26, 2024
@github-actions github-actions bot changed the title Python: remove _async from methods .Net: Python: remove _async from methods Feb 26, 2024
@markwallace-microsoft markwallace-microsoft added kernel Issues or pull requests impacting the core kernel kernel.core labels Feb 26, 2024
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .Net changes in this PR

@moonbox3
Copy link
Contributor

Please remove the .Net changes in this PR

@david-polo please pull latest main and merge with your branch, and the dotnet changes will go away. cc: @markwallace-microsoft

@markwallace-microsoft markwallace-microsoft removed .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Feb 27, 2024
@david-polo
Copy link
Contributor Author

Done

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Feb 27, 2024
Merged via the queue into microsoft:main with commit 079371d Feb 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants