-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Python: remove _async from methods #5160
Merged
markwallace-microsoft
merged 6 commits into
microsoft:main
from
Anant:update-astra-memory
Feb 27, 2024
Merged
.Net: Python: remove _async from methods #5160
markwallace-microsoft
merged 6 commits into
microsoft:main
from
Anant:update-astra-memory
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Pull requests for the Python Semantic Kernel
memory
labels
Feb 26, 2024
github-actions
bot
changed the title
remove _async from methods
Python: remove _async from methods
Feb 26, 2024
moonbox3
approved these changes
Feb 26, 2024
…-kernel-astra-memory into update-astra-memory
github-actions
bot
changed the title
Python: remove _async from methods
.Net: Python: remove _async from methods
Feb 26, 2024
…-kernel-astra-memory into update-astra-memory
markwallace-microsoft
added
kernel
Issues or pull requests impacting the core kernel
kernel.core
labels
Feb 26, 2024
markwallace-microsoft
requested changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the .Net changes in this PR
@david-polo please pull latest main and merge with your branch, and the dotnet changes will go away. cc: @markwallace-microsoft |
markwallace-microsoft
removed
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
kernel.core
labels
Feb 27, 2024
Done |
juliomenendez
approved these changes
Feb 27, 2024
markwallace-microsoft
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix error #5092.
Description
Contribution Checklist