.Net: Removing dependency on BinaryData class from content classes #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyMenshykh
requested review from
matthewbolanos,
stephentoub,
dmytrostruk,
RogerBarreto and
markwallace-microsoft
markwallace-microsoft
added
kernel
SergeyMenshykh
commented
Feb 28, 2024
dotnet/src/SemanticKernel.Abstractions/Contents/AudioContent.cs
Outdated
Show resolved
Hide resolved
|
@SergeyMenshykh So you need also remove BinaryData from imagecontent class. |
Right, the plan is to have a PR per type. So, there will be at least two more PRs - one for ImageContent, and the other one for BinaryContent. I updated the PR description to make it clear. |
markwallace-microsoft
approved these changes
Feb 28, 2024
Actually, it appears that the PR per class will be too excessive, so I'll push all the changes as one PR. |
2. Dependency on the System.Memory.Data package is removed
SergeyMenshykh
changed the title
3 tasks
SergeyMenshykh
changed the title
dotnet/src/SemanticKernel.Abstractions/Contents/ImageContent.cs
Outdated
Show resolved
Hide resolved
2. MediaType made optional for ImageContent to align with AudioContent and avaid breaking change
…geyMenshykh/semantic-kernel into remove-binarydata-dependency
4 tasks
dmytrostruk
approved these changes
Mar 4, 2024
…ting properties directly without initiating them through constructors.
…geyMenshykh/semantic-kernel into remove-binarydata-dependency
dmytrostruk
approved these changes
Mar 5, 2024
dotnet/src/Connectors/Connectors.OpenAI/AzureSdk/AzureOpenAITextToAudioClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.OpenAI/AzureSdk/OpenAITextToAudioClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/AudioContent.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
…geyMenshykh/semantic-kernel into remove-binarydata-dependency
dmytrostruk
approved these changes
Mar 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dmytrostruk
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Today, SemanticKernel.Abstractions package has unnecessary dependency on System.Memory.Data package which according to this issue #5226 should be removed to minimize number of dependencies and keep only absolutely necessary ones.
Description
This PR replaces the usage of the System.Memory.Data.BinaryData type with ReadonlyMemory in the AudioContent, BinaryContent, and ImageContent classes. It also removes the dependency of SemanticKernel.Abstractions on the System.Memory.Data package.
Contribution Checklist