Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: minor change so that inputs are not skipped in Planner example #5266

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

nkelly75
Copy link
Contributor

@nkelly75 nkelly75 commented Mar 1, 2024

Description

While learning Semantic Kernel (and having already run various other tests successfully) I wanted to try out the Planner example (described here). I added some sample inputs to SimulatedInputText. I then noticed that the chat loop was effectively skipping every second input due to a double call to ReadLine(). If there was an odd number of inputs we saw a failure due to the last ReadLine() returning null

The simple fix replaces the second ReadLine() call with the userInput variable from the first call.

Note: for illustration purposes, the PR includes my sample inputs commented out. These can be removed if necessary for approval.

Contribution Checklist

@nkelly75 nkelly75 requested a review from a team as a code owner March 1, 2024 18:45
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Mar 1, 2024
@markwallace-microsoft markwallace-microsoft self-assigned this Mar 2, 2024
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Mar 5, 2024
Merged via the queue into microsoft:main with commit e7f6dac Mar 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants