Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Update classes so namespaces are consistent and match project location #5275

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner March 2, 2024 15:07
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Mar 2, 2024
@github-actions github-actions bot changed the title Update classes so namespaces are consistent and match project location .Net: Update classes so namespaces are consistent and match project location Mar 2, 2024
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/huggingface_file_locations branch from efef40d to fe12d89 Compare March 3, 2024 19:52
@markwallace-microsoft markwallace-microsoft self-assigned this Mar 4, 2024
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/huggingface_file_locations branch from fe12d89 to 4487d3a Compare March 4, 2024 09:17
@RogerBarreto
Copy link
Member

Thanks for:

  • Splitting the ServiceCollection in it's own class, the other connectors are doing in the same, this is a good move.
  • Making internal the missing request/response Models, missed that.

REgarding the namespace change I don't fully agree, as this defeats the purpose of having specific modality namespaces where classes that could be in it are all mixed in Core.

@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/huggingface_file_locations branch from ab1d5e2 to ede6bf0 Compare March 4, 2024 12:27
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Mar 4, 2024
Merged via the queue into microsoft:main with commit a79fb4e Mar 4, 2024
18 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/huggingface_file_locations branch March 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants