Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Remove the service_id arg from the import plugin from prompt directory. Fix other notebooks. Formatting fixes. #5328

Merged

Conversation

moonbox3
Copy link
Contributor

@moonbox3 moonbox3 commented Mar 5, 2024

Motivation and Context

During the dev of the feature branch, the service_id was added as an arg to the import plugin from prompt directory; however, it was later removed but not removed from the notebooks.

Description

This PR:

  • Removes the service_id from the import_plugin_from_prompt_directory method as it is no longer present. Closes Python: AttributeError: 'Kernel' object has no attribute 'run_async' #5233
  • Uses the default service_id which is included as part of the stock plugins.
  • Add the function_name and plugin_name that were missing from create_function_from_prompt.
  • Run the latest ruff (0.3.0) and black (24.2.0) formatting on all python files. This is why other files show -- their formatting was updated.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner March 5, 2024 22:02
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Mar 5, 2024
@moonbox3 moonbox3 changed the title Python: Remove the service_id arg from the import plugin from prompt directory. Python: Remove the service_id arg from the import plugin from prompt directory. Fix other notebooks. Formatting fixes. Mar 5, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Mar 6, 2024
Merged via the queue into microsoft:main with commit bc3a8f3 Mar 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: AttributeError: 'Kernel' object has no attribute 'run_async'
4 participants