.Net: Reduce number of experimental flags used #5347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
|
Connectors like ollama and gemini are classified to SKEXP0001 or to memory connectors? |
SergeyMenshykh
approved these changes
Mar 6, 2024
dmytrostruk
approved these changes
Mar 6, 2024
RogerBarreto
reviewed
Mar 7, 2024
RogerBarreto
reviewed
Mar 7, 2024
RogerBarreto
reviewed
Mar 7, 2024
dotnet/src/Connectors/Connectors.HuggingFace.UnitTests/Connectors.HuggingFace.UnitTests.csproj
Show resolved
Hide resolved
Krzysztof318
suggested changes
Mar 8, 2024
dmytrostruk
approved these changes
Mar 11, 2024
justindhillon
pushed a commit
to justindhillon/semantic-kernel
that referenced
this pull request
Mar 11, 2024
### Motivation and Context Reduce the burden on developers who want to use SK experimental features by reducing the number of `SKEXP` flags to the following list: | SKEXP | Experimental Features Category | |-------|--------------------------------| | SKEXP0001 | Semantic Kernel core | | SKEXP0010 | OpenAI and Azure OpenAI services | | SKEXP0020 | Memory abstractions | | SKEXP0040 | Function types | | SKEXP0050 | Out-of-the-box plugins | | SKEXP0060 | Planners | | SKEXP0070 | AI connectors | | SKEXP0100 | Advanced Semantic Kernel features | ### Description Closes microsoft#5242 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Reduce the burden on developers who want to use SK experimental features by reducing the number of
SKEXPflags to the following list:Description
Closes #5242
Contribution Checklist