-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Google searches using Google.Apis.Customsearch.v1 #537
Conversation
@microsoft-github-policy-service agree |
A few thoughts:
|
The original code written was without |
Yes, current repo style guides are to use "this.". You should also run "dotnet format" in the "/dotnet" directory to gets most of the style adjustments made for free. This will help the "dotnet-format" gate pass. |
Ok I ran |
…OR.MINOR package version
…737) [see #537 - PR rebuilt to fix nuget dependency and merge conflicts] ### Motivation and Context Allow the usage of Google search equivalent to current Bing search implementation. ### Description Uses the Google.Apis.CustomSearchAPI.v1 packages to interface with the Google search API, this requires an API key from GCP and a custom search engine ID --------- Co-authored-by: Scott Kane <scottpkane94@gmail.com>
@ScottKane thanks for bringing this in! Unfortunately you unchecked the "allow maintainers to edit the PR" and we could not address some important changes, e.g. the dependency on an old nuget. I tried working around the block but between this and several conflicts it was taking too long (and apparently impossible), so I recreated your PR here #737, addressed the feedback, and added you as one of the contributors in the commit log. |
@dluc no problem, sorry I will look out for that next time I raise a PR |
…icrosoft#737) [see microsoft#537 - PR rebuilt to fix nuget dependency and merge conflicts] ### Motivation and Context Allow the usage of Google search equivalent to current Bing search implementation. ### Description Uses the Google.Apis.CustomSearchAPI.v1 packages to interface with the Google search API, this requires an API key from GCP and a custom search engine ID --------- Co-authored-by: Scott Kane <scottpkane94@gmail.com>
Motivation and Context
Allow the usage of Google search equivalent to current Bing search implementation.
Description
Uses the Google.Apis.Customsearch.v1 packages to interface with the Google search API, this requires an API key from GCP and a custom search engine ID
Contribution Checklist
dotnet format