Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Example notebook incorrect deployment name definition #5402

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

ABCurado
Copy link
Contributor

Description

On of the python example notebooks the deployment is read from the environment but it is being passed as a hard coded variable to the class constructor. This PR aims to correct it

Contribution Checklist

@ABCurado ABCurado requested a review from a team as a code owner March 10, 2024 16:46
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Mar 10, 2024
@ABCurado ABCurado changed the title Python example notebooks correct deployment name definition Python: Example notebook incorrect deployment name definition Mar 10, 2024
@markwallace-microsoft
Copy link
Member

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL499893781% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1042 1 💤 0 ❌ 0 🔥 17.227s ⏱️

@markwallace-microsoft
Copy link
Member

Py3.11 Test Coverage

Python 3.11 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL499893781% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.11 Unit Test Overview

Tests Skipped Failures Errors Time
1042 1 💤 0 ❌ 0 🔥 18.036s ⏱️

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 11, 2024

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL505999180% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1060 11 💤 0 ❌ 0 🔥 19.497s ⏱️

@markwallace-microsoft
Copy link
Member

Py3.9 Test Coverage

Python 3.9 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL499293981% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.9 Unit Test Overview

Tests Skipped Failures Errors Time
1042 2 💤 0 ❌ 0 🔥 20.855s ⏱️

@moonbox3 moonbox3 enabled auto-merge March 13, 2024 17:45
@moonbox3 moonbox3 added this pull request to the merge queue Mar 13, 2024
Merged via the queue into microsoft:main with commit 55be989 Mar 13, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants