Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Create clone of KernelFunction when it is added to a KernelPlugin #5422

Merged
merged 14 commits into from
Mar 15, 2024
Merged

.Net: Create clone of KernelFunction when it is added to a KernelPlugin #5422

merged 14 commits into from
Mar 15, 2024

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 11, 2024
@github-actions github-actions bot changed the title Clone KernelFunctions as they are added to a KernelPlugin .Net: Clone KernelFunctions as they are added to a KernelPlugin Mar 11, 2024
@dmytrostruk dmytrostruk mentioned this pull request Mar 12, 2024
Closed
@markwallace-microsoft markwallace-microsoft mentioned this pull request Mar 13, 2024
Closed
4 tasks
@markwallace-microsoft markwallace-microsoft changed the title .Net: Clone KernelFunctions as they are added to a KernelPlugin .Net: Create a copies of KernelFunctions as they are added to a KernelPlugin Mar 13, 2024
@markwallace-microsoft markwallace-microsoft marked this pull request as ready for review March 13, 2024 17:16
@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner March 13, 2024 17:16
@markwallace-microsoft markwallace-microsoft changed the title .Net: Create a copies of KernelFunctions as they are added to a KernelPlugin .Net: Create copies of KernelFunctions as they are added to a KernelPlugin Mar 13, 2024
RogerBarreto
RogerBarreto approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@RogerBarreto RogerBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, overall CLGTM

dotnet/src/SemanticKernel.Core/Functions/DefaultKernelPlugin.cs Outdated Show resolved Hide resolved
dotnet/src/SemanticKernel.Abstractions/Functions/KernelFunction.cs Outdated Show resolved Hide resolved
dotnet/src/SemanticKernel.UnitTests/Functions/KernelPluginTests.cs Outdated Show resolved Hide resolved
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_4706_clone_kernelfunction branch 2 times, most recently from 7def593 to 078dde6 Compare March 14, 2024 20:36
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_4706_clone_kernelfunction branch from 078dde6 to d8ebc23 Compare March 14, 2024 20:54
@markwallace-microsoft markwallace-microsoft changed the title .Net: Create copies of KernelFunctions as they are added to a KernelPlugin .Net: Create clone of KernelFunction when it is added to a KernelPlugin Mar 14, 2024
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Mar 15, 2024
Merged via the queue into microsoft:main with commit 3945bbb Mar 15, 2024
18 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/issue_4706_clone_kernelfunction branch March 15, 2024 10:53
@markwallace-microsoft markwallace-microsoft mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@dmytrostruk dmytrostruk dmytrostruk left review comments

@RogerBarreto RogerBarreto RogerBarreto approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees

@markwallace-microsoft markwallace-microsoft

Labels
documentation kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@markwallace-microsoft @stephentoub @dmytrostruk @RogerBarreto @SergeyMenshykh