Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add missing argument #5439

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Python: Add missing argument #5439

merged 5 commits into from
Mar 12, 2024

Conversation

sunyiming
Copy link
Contributor

@sunyiming sunyiming commented Mar 12, 2024

Motivation and Context

fix #5438

Description

Add missing argument in 05-using-the-planner.ipynb

Contribution Checklist

@sunyiming sunyiming requested a review from a team as a code owner March 12, 2024 03:31
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Mar 12, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 12, 2024

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL504499080% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1059 11 💤 0 ❌ 0 🔥 18.702s ⏱️

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 12, 2024

Py3.9 Test Coverage

Python 3.9 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL518198481% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.9 Unit Test Overview

Tests Skipped Failures Errors Time
1059 2 💤 0 ❌ 0 🔥 21.640s ⏱️

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 12, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL518798281% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1059 1 💤 0 ❌ 0 🔥 29.297s ⏱️

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 12, 2024

Py3.12 Test Coverage

Python 3.12 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL518798281% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.12 Unit Test Overview

Tests Skipped Failures Errors Time
1059 1 💤 0 ❌ 0 🔥 30.523s ⏱️

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 12, 2024

Py3.11 Test Coverage

Python 3.11 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL518798281% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.11 Unit Test Overview

Tests Skipped Failures Errors Time
1059 1 💤 0 ❌ 0 🔥 26.041s ⏱️

@moonbox3
Copy link
Contributor

Hi @sunyiming, thanks for fixing this. Can you please run black formatting in the sk/python dir and push the changes so that step can pass? Thank you.

@sunyiming
Copy link
Contributor Author

Hi @sunyiming, thanks for fixing this. Can you please run black formatting in the sk/python dir and push the changes so that step can pass? Thank you.

Hello. How to run black formatting? I tried to run poetry run black notebooks/05-using-the-planner.ipynb --check and got this:

Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install "black[jupyter]"``
No Python files are present to be formatted. Nothing to do 😴

In this failed job https://github.com/microsoft/semantic-kernel/actions/runs/8249273901/job/22561304222?pr=5439 it looks like something wrong with dependencies installing.

@moonbox3
Copy link
Contributor

Hi @sunyiming, thanks for fixing this. Can you please run black formatting in the sk/python dir and push the changes so that step can pass? Thank you.

Hello. How to run black formatting? I tried to run poetry run black notebooks/05-using-the-planner.ipynb --check and got this:

Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install "black[jupyter]"``
No Python files are present to be formatted. Nothing to do 😴

In this failed job https://github.com/microsoft/semantic-kernel/actions/runs/8249273901/job/22561304222?pr=5439 it looks like something wrong with dependencies installing.

Please install the black package via pip (it exists outside of the poetry venv). You should install pip install black==24.2.0 so that you're using the same version that the GitHub actions uses. Then once installed (you may need to restart your shell), navigate to the semantic-kernel/python directory and run black .. That should show the file was updated with the proper formatting.

@sunyiming
Copy link
Contributor Author

After running black .. under semantic-kernel/python, there is 215 files changed, 4765 insertions(+), 1500 deletions(-).
I think there must be something wrong. Is there any special configuration for black?

@moonbox3
Copy link
Contributor

After running black .. under semantic-kernel/python, there is 215 files changed, 4765 insertions(+), 1500 deletions(-). I think there must be something wrong. Is there any special configuration for black?

You're running it like this?

image

@sunyiming
Copy link
Contributor Author

@microsoft-github-policy-service agree

@moonbox3 moonbox3 enabled auto-merge March 12, 2024 18:02
@moonbox3 moonbox3 added this pull request to the merge queue Mar 12, 2024
Merged via the queue into microsoft:main with commit 178693f Mar 12, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Missing arugument in 05-using-the-planner.ipynb
4 participants