Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: planner love #5477

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Based on #5474 went into the using-the-planner notebook and made sure it works with the latest code.

Description

Moved all the planners to use '-' in line with the current work on new templates and planners, once that is in several extension classes can be changed.
Encountered several small bugs left over from changes over the last months.
Got through the whole notebook with results.

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner March 14, 2024 13:03
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel samples labels Mar 14, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 14, 2024

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py3242991%195–199, 201–205, 207–211, 219–221, 240, 246, 248–252, 254–258, 260–265, 267, 312–316, 333–338, 345, 349–353, 366, 625
semantic_kernel/planners
   basic_planner.py644825%19–21, 24, 135, 143–169, 181–204, 213–243
   plan.py2344680%48, 151–155, 187, 202–212, 246, 250, 258–259, 269–272, 287, 292–295, 310, 313–318, 336, 341, 344, 346, 353, 366–368, 373–377
semantic_kernel/planners/sequential_planner
   sequential_planner.py65691%71, 75, 106, 122, 131–132
   sequential_planner_parser.py771284%63–72, 92, 115–118
semantic_kernel/planners/stepwise_planner
   stepwise_planner.py22314037%12, 95, 109–127, 136–206, 227–230, 238–249, 252, 260–275, 278–314, 317–345, 348–353, 356–368, 371–374, 387–399
TOTAL522799981% 

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1131 11 💤 0 ❌ 0 🔥 20.122s ⏱️

Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a few small comments.

python/notebooks/05-using-the-planner.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@juliomenendez juliomenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! LGTM

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Mar 14, 2024
Merged via the queue into microsoft:main with commit 59c3a9f Mar 14, 2024
30 checks passed
@eavanvalkenburg eavanvalkenburg deleted the basic_planner_fix branch March 14, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants