.Net: Disable Azure SDK network timeout when a custom HttpClient is supplied #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
RogerBarreto
approved these changes
Mar 19, 2024
markwallace-microsoft
approved these changes
Mar 20, 2024
| @@ -749,6 +749,7 @@ internal static OpenAIClientOptions GetOpenAIClientOptions(HttpClient? httpClien | |||
| { | |||
| options.Transport = new HttpClientTransport(httpClient); | |||
| options.RetryPolicy = new RetryPolicy(maxRetries: 0); // Disable Azure SDK retry policy if and only if a custom HttpClient is provided. | |||
| options.Retry.NetworkTimeout = Timeout.InfiniteTimeSpan; // Disable Azure SDK default timeout | |||
There was a problem hiding this comment.
I'm a little bit late with the review but I would like to point out that there's a similar code over here - AzureOpenAITextToImageService GetClientOptions that needs to be updated as well.
There was a problem hiding this comment.
Created this #5569
There was a problem hiding this comment.
Could we do #5570 instead? It'd be good to avoid duplicated logic like this whenever possible. For example, the text-to-image one was also missing the header policy the other was adding... was that omission on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5310