-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Fix KustoMemoryStore reading Timestamp column data type #5600
.Net: Fix KustoMemoryStore reading Timestamp column data type #5600
Conversation
dotnet/src/Connectors/Connectors.Memory.Kusto/KustoMemoryStore.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment on the code duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a failing unit test that needs to be fixed
There was a mistake we won't get similarity in |
Updated test cases |
@mohammedtabish0 can you cd into the |
My bad forgot to run after the changes. |
Updated the code, on local dotnet build didn't gave it as an error but as a warning. Updated the code please review again. |
@markwallace-microsoft can we merge? |
dotnet/src/Connectors/Connectors.UnitTests/Memory/Kusto/KustoMemoryStoreTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Kusto/KustoMemoryRecord.cs
Outdated
Show resolved
Hide resolved
@mohammedtabish0 Can you look at the comments above and once these are resolved I'll get this merged |
Updated based on comments |
Fixes: #5599
Description
While reading data from Kusto proper data type should be used in KustoMemoryStore.