.Net: Remove use of Console.SetOut as it impacts other tests

[markwallace-microsoft]

Motivation and Context

Calls to Console.SetOut(this._testOutputHelper); impact tests that are using Console during tear down.
Removing these calls as the console output is already being captured in RedirectOutput.

Description

Contribution Checklist

• The code builds clean without any errors or warnings
• The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
• All unit tests pass, and I have added new tests where possible
• I didn't break anyone 😄

[stephentoub]

Removing these calls as the console output is already being captured in RedirectOutput.

Maybe I'm misunderstanding, but isn't RedirectOutput just a tee that forwards to both stdout and the ITestOutputHelper? If nothing writes to that RedirectOutput, then it's not actually doing anything, and it seems like the purpose of the Console.SetOut was to ensure that Console.Write calls would end up in both places.

[markwallace-microsoft]

Removing these calls as the console output is already being captured in RedirectOutput.

Maybe I'm misunderstanding, but isn't RedirectOutput just a tee that forwards to both stdout and the ITestOutputHelper? If nothing writes to that RedirectOutput, then it's not actually doing anything, and it seems like the purpose of the Console.SetOut was to ensure that Console.Write calls would end up in both places.

@stephentoub Yes, that is correct. In the tests where I removed the Console.SetOut they weren't testing for the existence of specific values in console output. The tests also weren't resetting the Console.Out at the end of the test which was causing an issue. The initial thought was to fix that problem but resetting the Console.Out but during stand-up we discussed this and decided to remove the unneeded the Console.SetOut calls because this pattern was likely being repeated when not strictly needed. There may be more code I can delete if there are places where the RedirectOutput isn't needed at all, I'll create a follow up PR to this one to fix that.

[stephentoub]

but during stand-up we discussed this and decided to remove the unneeded the Console.SetOut calls because this pattern was likely being repeated when not strictly needed. There may be more code I can delete if there are places where the RedirectOutput isn't needed at all, I'll create a follow up PR to this one to fix that.

Ok