Some behavioral / perf fixes for Embedding<T> #567
Merged
+106
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Clean up some
Embedding<T>
behaviors / perf issues.Description
ReadOnlySpan<T>
was cloning the array. It doesn't need to do that.default(Embedding<T>)
results in a struct that fails on a bunch of operations with NullReferenceExceptions if you try to use it. We've learned from experience withImmutableArray<T>
this is suboptimal. I've made it functional and behave equivalent to Empty... in fact, Empty is now justdefault
.Contribution Checklist
dotnet format