Python: Honor the function calling options if configured. #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Python 3.8 Test Coverage Report •
Python 3.8 Unit Test Overview
|
||||||||||||||||||||||||||||||
eavanvalkenburg
approved these changes
Mar 29, 2024
...rnel/planners/function_calling_stepwise_planner/function_calling_stepwise_planner_options.py
Show resolved
Hide resolved
juliomenendez
approved these changes
Apr 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
juliomenendez
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In the function calling stepwise planner, some settings like max_tokens (based on max_completion_tokens from the planner settings) and the max auto invoke attempts were not used.
Description
This PR fixes the issue where the prompt execution settings for chat completion wasn't using the function calling stepwise planner options, if configured. Closes #5661
Contribution Checklist