Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: fixing README.md example in python #5708

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

jsuarez-dev
Copy link
Contributor

Motivation and Context

This pull request fixed the example on the "get started guide" discussed here. Even though the maintainer closed the discussion and said that it was fixed, people kept finding the same error.

Description

Add the missing argument in the function create_function_from_prompt, and fix the names on the second example.

Contribution Checklist

@jsuarez-dev jsuarez-dev requested a review from a team as a code owner April 1, 2024 04:47
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Apr 1, 2024
@github-actions github-actions bot changed the title fixing README.md example in python Python: fixing README.md example in python Apr 1, 2024
@moonbox3 moonbox3 enabled auto-merge April 1, 2024 13:22
@moonbox3 moonbox3 added this pull request to the merge queue Apr 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2024
@moonbox3 moonbox3 enabled auto-merge April 1, 2024 15:32
@markwallace-microsoft
Copy link
Member

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL5540101782% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1206 11 💤 0 ❌ 0 🔥 22.556s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue Apr 1, 2024
@moonbox3 moonbox3 removed this pull request from the merge queue due to a manual request Apr 1, 2024
@moonbox3 moonbox3 added this pull request to the merge queue Apr 1, 2024
Merged via the queue into microsoft:main with commit 2558b01 Apr 1, 2024
30 checks passed
@jsuarez-dev jsuarez-dev deleted the fix-readme-python branch April 1, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants