-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed missing today() in TimeSkill #577
fixed missing today() in TimeSkill #577
Conversation
Instead of [SKFunction("Get the current date")]
public string Today()
{
// Example: Sunday, 12 January, 2025
return this.Date();
} You could just write [SKFunction("Get the current date")]
public string Today() => Date(); |
that's better one. |
@lemillermicrosoft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the concern of duplicate functions having some cost elsewhere. But I think that's something we should solve elsewhere as this will happen in the wild, too.
### Motivation and Context the method Today() in TimeSkill.cs and today() in TimeSkill.py was missing. Today must be an alias for Date. ### Description Add the method Today. Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
### Motivation and Context the method Today() in TimeSkill.cs and today() in TimeSkill.py was missing. Today must be an alias for Date. ### Description Add the method Today. Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Motivation and Context
the method Today() in TimeSkill.cs and today() in TimeSkill.py was missing.
Today must be an alias for Date.
Description
Add the method Today.
Contribution Checklist
dotnet format