Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: linter fix #578

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Python: linter fix #578

merged 4 commits into from
Apr 21, 2023

Conversation

joowon-dm-snu
Copy link
Contributor

Motivation and Context

lint fix for pre commit checks

Description

Contribution Checklist

@joowon-dm-snu joowon-dm-snu changed the title chore: pre-commit lint Python: linter fix Apr 21, 2023
@lemillermicrosoft lemillermicrosoft added the python Pull requests for the Python Semantic Kernel label Apr 21, 2023
@awharrison-28 awharrison-28 added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. PR: main labels Apr 21, 2023
awharrison-28
awharrison-28 previously approved these changes Apr 21, 2023
@joowon-dm-snu
Copy link
Contributor Author

black failed -> re-lint. maybe pre-commit need change?
image

@awharrison-28
Copy link
Contributor

@joowon-dm-snu try running poetry run black . standalone. I'm not sure why it's getting missed by the lumped command, but I think this will get this PR through.

@joowon-dm-snu
Copy link
Contributor Author

@awharrison-28 yup 1c945d7 this commit runs poetry run black .!

@joowon-dm-snu
Copy link
Contributor Author

running poetry run pre-commit run -c .conf/.pre-commit-config.yaml -a adds line 116
But poetry run black . doesn't like that change

    async def run_async(
            self,
            *functions: Any,
            input_context: Optional[SKContext] = None,
            input_vars: Optional[ContextVariables] = None,
            input_str: Optional[str] = None,
    ) -> SKContext:
            <----------- new line added
        # if the user passed in a context, prioritize it, but merge with any other inputs
        if input_context is not None:

image

@joowon-dm-snu
Copy link
Contributor Author

@awharrison-28 I found the issue, black version difference was the problem.
pre-commit uses black ver 22.3.0 but lint checker might using 23.1

@lemillermicrosoft lemillermicrosoft merged commit ba40c2b into microsoft:main Apr 21, 2023
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
lint fix for pre commit checks


Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants