Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C# simple planner #598

Merged
merged 1 commit into from Apr 26, 2023
Merged

Add C# simple planner #598

merged 1 commit into from Apr 26, 2023

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented Apr 22, 2023 •
edited

Motivation and Context

Need for a simple planner showing how to leverage semantic functions to implement Intent Detection pattern and turn it into a planner, selecting a function given a goal.

The planner also allows to provide a Planning capability using less powerful models, like GPT3 (text-davinci-002) and GPT3.5 (text-davinci-003, GPT turbo 3.5), where often the more advanced planner can hallucinate.

Fix one bug in "WriterSkill/ShortPoem/skprompt.txt" leading to incorrect results when the goal was missing a termination (period or new line)

Description

  • New package Microsoft.SemanticKernel.Planning.ActionPlannerextending the Planning namespace. The package is automatically installed, ie it's part of SK metapackage.
  • Move SequentialPlanner into the new package Microsoft.SemanticKernel.Planning.SequentialPlanner lib, part of the metapackage
  • Add new Action Planner.
  • Store planner prompts to skprompt.txt, using embedded resources to avoid files overwriting each other.

@dluc dluc added the PR: in progress Under development and/or addressing feedback label Apr 22, 2023
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 22, 2023
@dluc dluc force-pushed the dluc122plannerskill branch 6 times, most recently from f999a46 to 6215f6b Compare April 25, 2023 00:42
@dluc dluc added PR: ready for review All feedback addressed, ready for reviews and removed PR: in progress Under development and/or addressing feedback samples labels Apr 25, 2023
@dluc dluc force-pushed the dluc122plannerskill branch 3 times, most recently from 95bdead to c5c64ec Compare April 26, 2023 00:57
@dluc dluc changed the title C# Basic Planner Add C# simple planner Apr 26, 2023
@dluc dluc force-pushed the dluc122plannerskill branch 2 times, most recently from e63d646 to 6dfd726 Compare April 26, 2023 01:11
@dluc dluc force-pushed the dluc122plannerskill branch 2 times, most recently from a54a827 to 2511d40 Compare April 26, 2023 08:26
lemillermicrosoft
lemillermicrosoft requested changes Apr 26, 2023
View reviewed changes
dotnet/src/Extensions/Extensions.UnitTests/Extensions.UnitTests.csproj Show resolved Hide resolved
dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs Outdated Show resolved Hide resolved
dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs Show resolved Hide resolved
dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs Outdated Show resolved Hide resolved
dotnet/src/Extensions/Planning.SequentialPlanner/SKContextSequentialPlannerExtensions.cs Show resolved Hide resolved
dotnet/src/SemanticKernel.MetaPackage/SemanticKernel.MetaPackage.csproj Show resolved Hide resolved
dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs Show resolved Hide resolved
dotnet/src/Extensions/Planning.ActionPlanner/skprompt.txt Show resolved Hide resolved
@lemillermicrosoft lemillermicrosoft added PR: feedback to address Waiting for PR owner to address comments/questions and removed PR: ready for review All feedback addressed, ready for reviews labels Apr 26, 2023
@lemillermicrosoft lemillermicrosoft mentioned this pull request Apr 26, 2023
Merged
5 tasks
@dluc
Copy link
Collaborator Author

dluc commented Apr 26, 2023

all feedback addressed, a couple of TODOs for later

@dluc dluc added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: feedback to address Waiting for PR owner to address comments/questions labels Apr 26, 2023
lemillermicrosoft
lemillermicrosoft previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@lemillermicrosoft lemillermicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some nit comments. All can be resolved as appropriate.

dotnet/src/Extensions/Planning.SequentialPlanner/FunctionViewExtensions.cs Outdated Show resolved Hide resolved
dotnet/src/SemanticKernel/SkillDefinition/ImportSemanticSkillFromDirectory.cs Show resolved Hide resolved
dotnet/src/SemanticKernel/SkillDefinition/InlineFunctionsDefinitionExtension.cs Show resolved Hide resolved
dotnet/src/SemanticKernel/SkillDefinition/SkillCollection.cs Show resolved Hide resolved
@dluc dluc force-pushed the dluc122plannerskill branch 3 times, most recently from 28f2d37 to d3562ea Compare April 26, 2023 18:52
@shawncal shawncal dismissed their stale review April 26, 2023 19:47

Concerns addressed

@dluc dluc enabled auto-merge (squash) April 26, 2023 20:35
@dluc dluc merged commit 2607c14 into microsoft:main Apr 26, 2023
11 checks passed
Kevdome3000 pushed a commit to Kevdome3000/semantic-kernel that referenced this pull request Apr 26, 2023
@dluc @ChanceTheApp
Add C# simple planner (microsoft#598)
08e2f12 
Need for a simple planner showing how to leverage semantic functions to
implement Intent Detection pattern and turn it into a planner, selecting
a function given a goal.

The planner also allows to provide a Planning capability using less
powerful models, like GPT3 (text-davinci-002) and GPT3.5
(text-davinci-003, GPT turbo 3.5), where often the more advanced planner
can hallucinate.

Fix one bug in "WriterSkill/ShortPoem/skprompt.txt" leading to incorrect
results when the goal was missing a termination (period or new line)

* New package `Microsoft.SemanticKernel.Planning.ActionPlanner`extending
the Planning namespace. The package is automatically installed, ie it's
part of SK metapackage.
* Move SequentialPlanner into the new package
`Microsoft.SemanticKernel.Planning.SequentialPlanner` lib, part of the
metapackage
* Add new Action Planner.
* Store planner prompts to skprompt.txt, using embedded resources to
avoid files overwriting each other.
dluc added a commit that referenced this pull request Apr 29, 2023
@dluc
Add C# simple planner (#598)
9bdd66d 
### Motivation and Context

Need for a simple planner showing how to leverage semantic functions to
implement Intent Detection pattern and turn it into a planner, selecting
a function given a goal.

The planner also allows to provide a Planning capability using less
powerful models, like GPT3 (text-davinci-002) and GPT3.5
(text-davinci-003, GPT turbo 3.5), where often the more advanced planner
can hallucinate.

Fix one bug in "WriterSkill/ShortPoem/skprompt.txt" leading to incorrect
results when the goal was missing a termination (period or new line)

### Description

* New package `Microsoft.SemanticKernel.Planning.ActionPlanner`extending
the Planning namespace. The package is automatically installed, ie it's
part of SK metapackage.
* Move SequentialPlanner into the new package
`Microsoft.SemanticKernel.Planning.SequentialPlanner` lib, part of the
metapackage
* Add new Action Planner.
* Store planner prompts to skprompt.txt, using embedded resources to
avoid files overwriting each other.
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
@dluc
Add C# simple planner (microsoft#598)
8bf0fb3 
### Motivation and Context

Need for a simple planner showing how to leverage semantic functions to
implement Intent Detection pattern and turn it into a planner, selecting
a function given a goal.

The planner also allows to provide a Planning capability using less
powerful models, like GPT3 (text-davinci-002) and GPT3.5
(text-davinci-003, GPT turbo 3.5), where often the more advanced planner
can hallucinate.

Fix one bug in "WriterSkill/ShortPoem/skprompt.txt" leading to incorrect
results when the goal was missing a termination (period or new line)

### Description

* New package `Microsoft.SemanticKernel.Planning.ActionPlanner`extending
the Planning namespace. The package is automatically installed, ie it's
part of SK metapackage.
* Move SequentialPlanner into the new package
`Microsoft.SemanticKernel.Planning.SequentialPlanner` lib, part of the
metapackage
* Add new Action Planner.
* Store planner prompts to skprompt.txt, using embedded resources to
avoid files overwriting each other.
@dluc dluc deleted the dluc122plannerskill branch June 14, 2023 01:14
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
@dluc
Add C# simple planner (microsoft#598)
3f19714 
### Motivation and Context

Need for a simple planner showing how to leverage semantic functions to
implement Intent Detection pattern and turn it into a planner, selecting
a function given a goal.

The planner also allows to provide a Planning capability using less
powerful models, like GPT3 (text-davinci-002) and GPT3.5
(text-davinci-003, GPT turbo 3.5), where often the more advanced planner
can hallucinate.

Fix one bug in "WriterSkill/ShortPoem/skprompt.txt" leading to incorrect
results when the goal was missing a termination (period or new line)

### Description

* New package `Microsoft.SemanticKernel.Planning.ActionPlanner`extending
the Planning namespace. The package is automatically installed, ie it's
part of SK metapackage.
* Move SequentialPlanner into the new package
`Microsoft.SemanticKernel.Planning.SequentialPlanner` lib, part of the
metapackage
* Add new Action Planner.
* Store planner prompts to skprompt.txt, using embedded resources to
avoid files overwriting each other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerBarreto RogerBarreto RogerBarreto left review comments

@lemillermicrosoft lemillermicrosoft lemillermicrosoft approved these changes

@shawncal shawncal shawncal left review comments

Assignees

@lemillermicrosoft lemillermicrosoft

Labels
.NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dluc @RogerBarreto @lemillermicrosoft @shawncal