Adding Multiple Skill Directories Simplification + Integration Tests readme changes #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents and focus in davinci-003
github-actions
bot
added
.NET
RogerBarreto
changed the title
RogerBarreto
added
the
PR: ready for review
shawncal
force-pushed
the
features/import-multiple-skills
branch
from
1068129
to
4cf8ebd
Compare
…ents and focus in davinci-003
shawncal
approved these changes
Apr 23, 2023
dotnet/src/SemanticKernel/KernelExtensions/ImportSemanticSkillFromDirectory.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel/KernelExtensions/ImportSemanticSkillFromDirectory.cs
Show resolved
Hide resolved
shawncal
requested changes
Apr 23, 2023
lemillermicrosoft
previously approved these changes
Apr 24, 2023
dotnet/src/SemanticKernel/KernelExtensions/ImportSemanticSkillFromDirectory.cs
Show resolved
Hide resolved
lemillermicrosoft
added
the
PR: ready to merge
shawncal
previously approved these changes
Apr 26, 2023
|
@RogerBarreto Looks like we've got a build break after merge. Can you take a look please? Once that's resolved, should be good to go. |
RogerBarreto
dismissed stale reviews from shawncal and lemillermicrosoft
via
109efdc
shawncal
approved these changes
Apr 26, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
…readme changes (#599) ### Motivation and Context - Improvement It is a common scenario having to import multiple skills. Adding this as a `param` array to the extension will reduce number of calls and improve cleanliness. ### Description As part of this PR I also spotted missing in the Readme the recommendation on using UserSecrets for Integration Tests. Changed the readme and example config files to use davinci-003 models as our current standard for integration tests.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…readme changes (microsoft#599) ### Motivation and Context - Improvement It is a common scenario having to import multiple skills. Adding this as a `param` array to the extension will reduce number of calls and improve cleanliness. ### Description As part of this PR I also spotted missing in the Readme the recommendation on using UserSecrets for Integration Tests. Changed the readme and example config files to use davinci-003 models as our current standard for integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context - Improvement
It is a common scenario having to import multiple skills.
Adding this as a
paramarray to the extension will reduce number of calls and improve cleanliness.Description
As part of this PR I also spotted missing in the Readme the recommendation on using UserSecrets for Integration Tests.
Changed the readme and example config files to use davinci-003 models as our current standard for integration tests.
Contribution Checklist
dotnet format