-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Samples Restructuring - Phase 2 #6005
Merged
RogerBarreto
merged 59 commits into
microsoft:main
from
RogerBarreto:features/samples-restructure-phase2
Apr 29, 2024
Merged
.Net Samples Restructuring - Phase 2 #6005
RogerBarreto
merged 59 commits into
microsoft:main
from
RogerBarreto:features/samples-restructure-phase2
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
approved these changes
Apr 26, 2024
dotnet/samples/Concepts/Memory/HuggingFace_EmbeddingGeneration.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Concepts/LocalModels/HuggingFace_ChatCompletionWithTGI.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Concepts/TextGeneration/HuggingFace_TextGeneration.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few minor comments that should be quick to fix
…com/RogerBarreto/semantic-kernel into features/samples-restructure-phase2
markwallace-microsoft
approved these changes
Apr 29, 2024
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
## Phase 2 - Sample Restructuring - Removal of Examples numbering - Decomposing `KernelSyntaxExamples` into meaningful Feature base folders within `Concepts`. - Update current sample projects to use `sample` centric `InternalUtilities` reducing code repetition - Update SDK projects type to be correctly idenfified as xUnit Test projects - Update projects to be implicit using friendly, reducing considerably the extra lines of code for every sample. - Decomposing `Concepts\AgentSyntax` into `Concepts\Agents` - Decomposing `Concepts\AgentSyntax\GettingStarted` into a new root dedicated `GettingStartedWithAgents`
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
## Phase 2 - Sample Restructuring - Removal of Examples numbering - Decomposing `KernelSyntaxExamples` into meaningful Feature base folders within `Concepts`. - Update current sample projects to use `sample` centric `InternalUtilities` reducing code repetition - Update SDK projects type to be correctly idenfified as xUnit Test projects - Update projects to be implicit using friendly, reducing considerably the extra lines of code for every sample. - Decomposing `Concepts\AgentSyntax` into `Concepts\Agents` - Decomposing `Concepts\AgentSyntax\GettingStarted` into a new root dedicated `GettingStartedWithAgents`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
kernel.core
kernel
Issues or pull requests impacting the core kernel
memory
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 - Sample Restructuring
Resolves #3978
Resolves #5976
KernelSyntaxExamples
into meaningful Feature base folders withinConcepts
.sample
centricInternalUtilities
reducing code repetitionConcepts\AgentSyntax
intoConcepts\Agents
Concepts\AgentSyntax\GettingStarted
into a new root dedicatedGettingStartedWithAgents