Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Samples Restructuring - Phase 2 #6005

Merged

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented Apr 25, 2024

Phase 2 - Sample Restructuring

Resolves #3978
Resolves #5976

  • Removal of Examples numbering
  • Decomposing KernelSyntaxExamples into meaningful Feature base folders within Concepts.
  • Update current sample projects to use sample centric InternalUtilities reducing code repetition
  • Update SDK projects type to be correctly idenfified as xUnit Test projects
  • Update projects to be implicit using friendly, reducing considerably the extra lines of code for every sample.
  • Decomposing Concepts\AgentSyntax into Concepts\Agents
  • Decomposing Concepts\AgentSyntax\GettingStarted into a new root dedicated GettingStartedWithAgents

@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Apr 26, 2024
@RogerBarreto RogerBarreto removed the PR: in progress Under development and/or addressing feedback label Apr 26, 2024
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor comments that should be quick to fix

@RogerBarreto RogerBarreto added this pull request to the merge queue Apr 29, 2024
Merged via the queue into microsoft:main with commit c545c7d Apr 29, 2024
15 checks passed
@RogerBarreto RogerBarreto deleted the features/samples-restructure-phase2 branch April 29, 2024 15:55
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
## Phase 2 - Sample Restructuring

- Removal of Examples numbering 
- Decomposing `KernelSyntaxExamples` into meaningful Feature base
folders within `Concepts`.
- Update current sample projects to use `sample` centric
`InternalUtilities` reducing code repetition
- Update SDK projects type to be correctly idenfified as xUnit Test
projects
- Update projects to be implicit using friendly, reducing considerably
the extra lines of code for every sample.
- Decomposing `Concepts\AgentSyntax` into `Concepts\Agents`
- Decomposing `Concepts\AgentSyntax\GettingStarted` into a new root
dedicated `GettingStartedWithAgents`
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
## Phase 2 - Sample Restructuring

- Removal of Examples numbering 
- Decomposing `KernelSyntaxExamples` into meaningful Feature base
folders within `Concepts`.
- Update current sample projects to use `sample` centric
`InternalUtilities` reducing code repetition
- Update SDK projects type to be correctly idenfified as xUnit Test
projects
- Update projects to be implicit using friendly, reducing considerably
the extra lines of code for every sample.
- Decomposing `Concepts\AgentSyntax` into `Concepts\Agents`
- Decomposing `Concepts\AgentSyntax\GettingStarted` into a new root
dedicated `GettingStartedWithAgents`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation kernel.core kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
3 participants