Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Fixing minor defects: Disposing cursor too early also wrong sequence on constructor #6125

Merged
merged 2 commits into from
May 6, 2024

Conversation

danqzt
Copy link
Contributor

@danqzt danqzt commented May 5, 2024

Motivation and Context

Description

  1. Fixing the wrong sequence in the constructor of MemoryRecordMetadata
  2. The cursor is disposed to early, resulting the SearchAsync failed.

Contribution Checklist

@danqzt danqzt requested a review from a team as a code owner May 5, 2024 12:27
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels May 5, 2024
@github-actions github-actions bot changed the title .NET: Fixing minor defects: Disposing cursor too early also wrong sequence on constructor .Net: Fixing minor defects: Disposing cursor too early also wrong sequence on constructor May 5, 2024
@danqzt
Copy link
Contributor Author

danqzt commented May 5, 2024 via email

@dmytrostruk dmytrostruk added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@dmytrostruk dmytrostruk enabled auto-merge May 6, 2024 16:46
@dmytrostruk dmytrostruk added this pull request to the merge queue May 6, 2024
Merged via the queue into microsoft:main with commit 7ba789d May 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants