Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: allow openapi runner to use a custom client #6226

Merged
merged 3 commits into from
May 13, 2024

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

A custom client was used to get the openapi spec but it wasn't passed down into the openapi runner.

Description

Pass the custom client into the open api runner if desired. Fix param parsing and samples.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner May 13, 2024 21:08
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 13, 2024
@moonbox3 moonbox3 enabled auto-merge May 13, 2024 21:09
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 13, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/openapi_plugin
   openapi_function_execution_parameters.py23196%33
   openapi_manager.py1411589%15, 61–74, 104, 145, 150, 280, 350–363
TOTAL587693484% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1287 1 💤 0 ❌ 0 🔥 14.858s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue May 13, 2024
Merged via the queue into microsoft:main with commit 1692207 May 13, 2024
25 checks passed
@moonbox3 moonbox3 deleted the openapi_http_client branch May 13, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants