Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Updated notebooks #6273

Merged
merged 1 commit into from
May 15, 2024
Merged

.Net: Updated notebooks #6273

merged 1 commit into from
May 15, 2024

Conversation

dmytrostruk
Copy link
Member

Motivation and Context

Resolves: #6247

Fixed path issues and updated Microsoft.SemanticKernel version to 1.11.1.

Contribution Checklist

@dmytrostruk dmytrostruk self-assigned this May 15, 2024
@dmytrostruk dmytrostruk requested a review from a team as a code owner May 15, 2024 20:43
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label May 15, 2024
@dmytrostruk dmytrostruk mentioned this pull request May 15, 2024
Closed
@dmytrostruk dmytrostruk changed the title .Net: Updated .NET notebooks .Net: Updated notebooks May 15, 2024
@dmytrostruk dmytrostruk added this pull request to the merge queue May 15, 2024
Merged via the queue into microsoft:main with commit c22f42a May 15, 2024
16 checks passed
@dmytrostruk dmytrostruk deleted the update-dotnet-notebooks branch May 15, 2024 23:01
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request May 18, 2024
@johnoliver
Fix microsoft#6325 and microsoft#6273
17c9fff
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request May 18, 2024
@johnoliver
Fix microsoft#6325 and microsoft#6273
27ea962
github-merge-queue bot pushed a commit that referenced this pull request May 20, 2024
@johnoliver
Java: Fix #6325 and #6273 (#6330)
bb5103a 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@johnoliver
Java: Fix microsoft#6325 and microsoft#6273 (microsoft#6330)
600e3ac 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@johnoliver
Java: Fix microsoft#6325 and microsoft#6273 (microsoft#6330)
875baef 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

Assignees

@dmytrostruk dmytrostruk

Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Dotnet notebooks not working out of the box
3 participants
@dmytrostruk @SergeyMenshykh @markwallace-microsoft