Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Create an experimental class and function decorator. #6298

Merged
merged 3 commits into from
May 16, 2024

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

There may be classes or functions inside of SK Python that should be deemed as experimental. Currently in Python there is no out-of-the-box way to get the decorator.

Description

As there is a name clash with using experimental as the decorator name, we are introducing two decorators: one experimental_class and one experimental_function. The note that "This {function | class} is experimental and may change in the future" is included in the docstring and a bool is_experimental on the class is added.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner May 16, 2024 17:53
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 16, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 16, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/utils
   experimental_decorator.py16194%22
TOTAL6158106383% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1313 1 💤 0 ❌ 0 🔥 15.450s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@moonbox3 moonbox3 enabled auto-merge May 16, 2024 18:08
@moonbox3 moonbox3 added this pull request to the merge queue May 16, 2024
Merged via the queue into microsoft:main with commit d9aa617 May 16, 2024
25 checks passed
@moonbox3 moonbox3 deleted the experimental_decorator branch May 16, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants