Move authority out from Constants.ts to the .env (env.example) #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigomatic
added
PR: ready for review
hathind-ms
approved these changes
Apr 25, 2023
adrianwyatt
requested changes
Apr 25, 2023
adrianwyatt
added
PR: feedback to address
adrianwyatt
approved these changes
Apr 25, 2023
adrianwyatt
added
PR: ready to merge
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context Small PR to shift the AAD authority out of the Constants.ts file to the .env alongside the AAD client id. Developers may wish to change the authority from /common to the MSA endpoint /9188040d-6c67-4c5b-b112-36a304b66dad if their AAD app is for consumer MSA logins or to their own tenant for other reasons. ### Description Change only the location of the default authority to the env.example file. The expectation is that the developer will rename the env.example file to .env
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…soft#635) ### Motivation and Context Small PR to shift the AAD authority out of the Constants.ts file to the .env alongside the AAD client id. Developers may wish to change the authority from /common to the MSA endpoint /9188040d-6c67-4c5b-b112-36a304b66dad if their AAD app is for consumer MSA logins or to their own tenant for other reasons. ### Description Change only the location of the default authority to the env.example file. The expectation is that the developer will rename the env.example file to .env
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…soft#635) ### Motivation and Context Small PR to shift the AAD authority out of the Constants.ts file to the .env alongside the AAD client id. Developers may wish to change the authority from /common to the MSA endpoint /9188040d-6c67-4c5b-b112-36a304b66dad if their AAD app is for consumer MSA logins or to their own tenant for other reasons. ### Description Change only the location of the default authority to the env.example file. The expectation is that the developer will rename the env.example file to .env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Small PR to shift the AAD authority out of the Constants.ts file to the .env alongside the AAD client id. Developers may wish to change the authority from /common to the MSA endpoint /9188040d-6c67-4c5b-b112-36a304b66dad if their AAD app is for consumer MSA logins or to their own tenant for other reasons.
Description
Change only the location of the default authority to the env.example file. The expectation is that the developer will rename the env.example file to .env
Contribution Checklist
dotnet format