Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: split kernel into kernel extensions for relevant pieces #6361

Merged
merged 2 commits into from
May 22, 2024

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

In order to keep better track of related pieces within the Kernel, including easier unit testing, this PR splits the kernel into pieces that are self-contained, but abstract.

Description

New:

  • KernelServicesExtension
  • KernelFunctionExtension
  • KernelReliabilityExtension

Changed:

  • Kernel, now imports the new ones.
  • KernelFiltersExtension, moved to filters folder, in line with the rest.

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner May 22, 2024 10:00
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 22, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 22, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py953959%127, 134–143, 173, 183–191, 263–299
semantic_kernel/connectors/ai/open_ai/services
   open_ai_chat_completion_base.py2129356%98, 118, 143–147, 171, 175, 191–196, 213–241, 244–255, 273–280, 291–299, 315–322, 343, 351, 357–363, 375–381, 412, 451, 453–454, 459–464, 468–475, 497, 506–515
semantic_kernel/functions
   kernel_function.py82298%145, 165
   kernel_function_extension.py1261191%45, 47, 115–116, 343, 364–366, 402, 404, 414
   kernel_function_from_prompt.py157796%149–150, 171, 191, 216, 237, 317
TOTAL6260103184% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1341 1 💤 0 ❌ 0 🔥 13.215s ⏱️

Copy link

@Josephrp Josephrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome pythonic refactor 👏🏻👏🏻

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 22, 2024
Merged via the queue into microsoft:main with commit eccad33 May 22, 2024
25 checks passed
@eavanvalkenburg eavanvalkenburg deleted the split_kernel branch May 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants