.Net: Include request metadata in KernelException if response cannot be serialized #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
markwallace-microsoft
force-pushed
the
users/markwallace/issue_6405
branch
from
3178bdd
to
d97aee5
Compare
markwallace-microsoft
changed the title
dotnet/src/Functions/Functions.OpenApi/RestApiOperationRunner.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
May 27, 2024
markwallace-microsoft
force-pushed
the
users/markwallace/issue_6405
branch
2 times, most recently
from
a34e2bf
to
673166b
Compare
markwallace-microsoft
changed the title
markwallace-microsoft
force-pushed
the
users/markwallace/issue_6405
branch
2 times, most recently
from
ba2f820
to
bef67e0
Compare
markwallace-microsoft
force-pushed
the
users/markwallace/issue_6405
branch
from
bef67e0
to
0337564
Compare
markwallace-microsoft
added
the
kernel
dmytrostruk
reviewed
May 29, 2024
markwallace-microsoft
force-pushed
the
users/markwallace/issue_6405
branch
from
d79f252
to
5f7b482
Compare
SergeyMenshykh
approved these changes
May 30, 2024
dmytrostruk
approved these changes
May 30, 2024
dotnet/src/SemanticKernel.Abstractions/Http/HttpOperationException.cs
Outdated
Show resolved
Hide resolved
…tion.cs Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
dmytrostruk
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We include additional metadata in
HttpOperationExceptioni.e. request uri, payload, etc. When the response serialization fails we currently throw aKernelExceptionwhich doesn't include the HTTP request metadata. This PR changes which exception is thrown toHttpOperationExceptionso we have one type of exception for clients to catch and this includes all of the additional metadata . This is a behaviour change but it enables clients to catch a single exception and to get access to the request uri, payload, etc.Description
Contribution Checklist