-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open API GitHub Plugin Skill + Frontend Auth (MSAL + Basic / PAT) #641
Merged
adrianwyatt
merged 47 commits into
microsoft:main
from
teresaqhoang:openapi-github-pr-skill
May 1, 2023
Merged
Open API GitHub Plugin Skill + Frontend Auth (MSAL + Basic / PAT) #641
adrianwyatt
merged 47 commits into
microsoft:main
from
teresaqhoang:openapi-github-pr-skill
May 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into openapi-github-pr-skill
github-actions
bot
added
.NET
Issue or Pull requests regarding .NET code
kernel.core
labels
Apr 25, 2023
amsacha
reviewed
Apr 25, 2023
dotnet/src/Skills/Skills.OpenAPI/Skills/GitHubSkill/openapi.json
Outdated
Show resolved
Hide resolved
amsacha
reviewed
Apr 25, 2023
samples/apps/copilot-chat-app/webapi/Controllers/SemanticKernelController.cs
Outdated
Show resolved
Hide resolved
amsacha
reviewed
Apr 25, 2023
glahaye
reviewed
Apr 28, 2023
samples/apps/copilot-chat-app/webapi/Controllers/SemanticKernelController.cs
Outdated
Show resolved
Hide resolved
amsacha
reviewed
Apr 28, 2023
adrianwyatt
requested changes
Apr 28, 2023
dotnet/src/SemanticKernel.Abstractions/Connectors/WebApi/Rest/RestApiOperationRunner.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Skills/Skills.OpenAPI/Extensions/KernelOpenApiExtensions.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/SemanticKernelController.cs
Outdated
Show resolved
Hide resolved
Vivihung
reviewed
Apr 28, 2023
samples/apps/copilot-chat-app/webapi/Controllers/SemanticKernelController.cs
Show resolved
Hide resolved
Vivihung
reviewed
Apr 28, 2023
samples/apps/copilot-chat-app/webapp/src/redux/features/plugins/pluginsSlice.ts
Show resolved
Hide resolved
Vivihung
reviewed
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a pass on the changes in Copilot Chats. LGTM and have a couple curious questions. I might not be helpful in changes outside of Copilot Chats.
amsacha
suggested changes
May 1, 2023
samples/dotnet/kernel-syntax-examples/Example22_a_OpenApiSkill_AzureKeyVault.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Skills/Skills.OpenAPI/Extensions/KernelOpenApiExtensions.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/SemanticKernelController.cs
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/libs/connectors/useConnectors.ts
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/redux/features/plugins/pluginsSlice.ts
Show resolved
Hide resolved
adrianwyatt
requested changes
May 1, 2023
dotnet/src/Skills/Skills.OpenAPI/Extensions/KernelOpenApiExtensions.cs
Outdated
Show resolved
Hide resolved
adrianwyatt
approved these changes
May 1, 2023
amsacha
approved these changes
May 1, 2023
teresaqhoang
added
the
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
label
May 1, 2023
awharrison-28
pushed a commit
to awharrison-28/semantic-kernel
that referenced
this pull request
May 1, 2023
…crosoft#641) ### Motivation and Context This PR adds: - Swagger files detailing List and Get Pull Request(s) functions. - Example 22 c on how to leverage imported OpenAPI GitHub Skill - Basic (+ User PAT) and Msal Authentication flows in Copilot chat for connector plug-ins, sending auth data if user enables plug-in - Parsing headers in SemanticKernelController to import respective OpenAPI Skill if auth information is provided ### Description ![image](https://user-images.githubusercontent.com/125500434/234473631-cb01eac2-12b7-4f78-a939-bc99f70d2184.png) ![image](https://user-images.githubusercontent.com/125500434/234473648-976fa0a5-f857-4693-b72b-b2f85a4d1eee.png) ![image](https://user-images.githubusercontent.com/125500434/234473826-9d0264a8-1e4c-464e-a59f-84affa1ae99a.png) ![image](https://user-images.githubusercontent.com/125500434/234473842-1efcbf7d-4bd4-4015-b903-c13bdd173191.png) ![image](https://user-images.githubusercontent.com/125500434/235235863-1353180f-f679-4445-afaf-4b4c2154d922.png)
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
…crosoft#641) ### Motivation and Context This PR adds: - Swagger files detailing List and Get Pull Request(s) functions. - Example 22 c on how to leverage imported OpenAPI GitHub Skill - Basic (+ User PAT) and Msal Authentication flows in Copilot chat for connector plug-ins, sending auth data if user enables plug-in - Parsing headers in SemanticKernelController to import respective OpenAPI Skill if auth information is provided ### Description ![image](https://user-images.githubusercontent.com/125500434/234473631-cb01eac2-12b7-4f78-a939-bc99f70d2184.png) ![image](https://user-images.githubusercontent.com/125500434/234473648-976fa0a5-f857-4693-b72b-b2f85a4d1eee.png) ![image](https://user-images.githubusercontent.com/125500434/234473826-9d0264a8-1e4c-464e-a59f-84affa1ae99a.png) ![image](https://user-images.githubusercontent.com/125500434/234473842-1efcbf7d-4bd4-4015-b903-c13bdd173191.png) ![image](https://user-images.githubusercontent.com/125500434/235235863-1353180f-f679-4445-afaf-4b4c2154d922.png)
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…crosoft#641) ### Motivation and Context This PR adds: - Swagger files detailing List and Get Pull Request(s) functions. - Example 22 c on how to leverage imported OpenAPI GitHub Skill - Basic (+ User PAT) and Msal Authentication flows in Copilot chat for connector plug-ins, sending auth data if user enables plug-in - Parsing headers in SemanticKernelController to import respective OpenAPI Skill if auth information is provided ### Description ![image](https://user-images.githubusercontent.com/125500434/234473631-cb01eac2-12b7-4f78-a939-bc99f70d2184.png) ![image](https://user-images.githubusercontent.com/125500434/234473648-976fa0a5-f857-4693-b72b-b2f85a4d1eee.png) ![image](https://user-images.githubusercontent.com/125500434/234473826-9d0264a8-1e4c-464e-a59f-84affa1ae99a.png) ![image](https://user-images.githubusercontent.com/125500434/234473842-1efcbf7d-4bd4-4015-b903-c13bdd173191.png) ![image](https://user-images.githubusercontent.com/125500434/235235863-1353180f-f679-4445-afaf-4b4c2154d922.png)
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…crosoft#641) ### Motivation and Context This PR adds: - Swagger files detailing List and Get Pull Request(s) functions. - Example 22 c on how to leverage imported OpenAPI GitHub Skill - Basic (+ User PAT) and Msal Authentication flows in Copilot chat for connector plug-ins, sending auth data if user enables plug-in - Parsing headers in SemanticKernelController to import respective OpenAPI Skill if auth information is provided ### Description ![image](https://user-images.githubusercontent.com/125500434/234473631-cb01eac2-12b7-4f78-a939-bc99f70d2184.png) ![image](https://user-images.githubusercontent.com/125500434/234473648-976fa0a5-f857-4693-b72b-b2f85a4d1eee.png) ![image](https://user-images.githubusercontent.com/125500434/234473826-9d0264a8-1e4c-464e-a59f-84affa1ae99a.png) ![image](https://user-images.githubusercontent.com/125500434/234473842-1efcbf7d-4bd4-4015-b903-c13bdd173191.png) ![image](https://user-images.githubusercontent.com/125500434/235235863-1353180f-f679-4445-afaf-4b4c2154d922.png)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds:
Description
Contribution Checklist
dotnet format