Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: further improvements to checks and docs in dev_setup #6445

Merged
merged 5 commits into from
May 31, 2024

Conversation

eavanvalkenburg
Copy link
Member

@eavanvalkenburg eavanvalkenburg commented May 30, 2024

Motivation and Context

Added a section on documentation to the DEV_SETUP
Added a check for the copyright row to pre-commit
Closes #5629

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner May 30, 2024 09:35
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation memory labels May 30, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 30, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py953860%127, 134–143, 183–191, 262–298
   kernel_pydantic.py21195%51
semantic_kernel/connectors/ai/google_palm
   gp_prompt_execution_settings.py30293%45–46
semantic_kernel/connectors/ai/google_palm/services
   gp_chat_completion.py691677%68, 155–160, 172–173, 212, 215, 218–219, 227, 231–232, 240
semantic_kernel/connectors/ai/hugging_face
   __init__.py440%3–13
   hf_prompt_execution_settings.py19190%1–38
semantic_kernel/connectors/ai/ollama/services
   ollama_chat_completion.py71692%56, 92, 112, 129, 161, 180
   ollama_text_completion.py43198%92
   ollama_text_embedding.py27196%8
semantic_kernel/connectors/ai/open_ai/prompt_execution_settings
   azure_chat_prompt_execution_settings.py66395%89–96, 109
semantic_kernel/connectors/ai/open_ai/services
   azure_chat_completion.py873461%141, 147–148, 157–158, 163–180, 184–191, 203–214
   open_ai_chat_completion_base.py2209955%97, 117, 142–146, 170, 174, 190–195, 212–240, 243–254, 272–279, 290–298, 314–321, 342, 350, 356–362, 374–380, 411, 450, 452–453, 458–463, 467–474, 478–490, 512, 521–532
   open_ai_handler.py45491%66–67, 79–80
   open_ai_text_completion.py25292%61, 80
   open_ai_text_embedding.py24483%59–60, 62, 80
   open_ai_text_embedding_base.py27293%9, 43
semantic_kernel/connectors/openapi_plugin
   openapi_manager.py582164%92–125
   openapi_parser.py85495%69, 92, 95, 126
   openapi_runner.py996435%51–53, 59–60, 66–80, 84–100, 104–106, 110–112, 115–118, 127–170
semantic_kernel/connectors/openapi_plugin/models
   rest_api_operation.py1245258%73–79, 83–100, 104–106, 110–123, 127–138, 142–154, 184, 201, 214, 249, 254, 258, 273, 290
semantic_kernel/connectors/search_engine
   bing_connector.py33330%3–74
   google_connector.py38380%3–67
semantic_kernel/core_plugins
   conversation_summary_plugin.py16850%37–38, 64–73
   http_plugin.py39392%58, 82, 101
semantic_kernel/core_plugins/sessions_python_tool
   sessions_python_plugin.py1031486%59–61, 81, 84, 89–95, 135, 182, 186
semantic_kernel/functions
   function_result.py30970%49, 51–52, 62–67
   kernel_function_extension.py126993%45, 47, 338, 358–360, 396, 398, 408
   kernel_function_from_prompt.py162796%165–166, 187, 207, 232, 252, 335
semantic_kernel/planners
   plan.py2364780%52, 162–164, 197, 214–227, 264, 269, 277–278, 288–291, 308, 313–316, 332, 335–340, 358, 363, 366, 368, 375, 389–391, 396–400
   planner_extensions.py32320%3–74
semantic_kernel/planners/function_calling_stepwise_planner
   function_calling_stepwise_planner.py1114361%124–214, 250–255
semantic_kernel/planners/sequential_planner
   sequential_planner.py65691%69, 73, 105, 121, 130–131
   sequential_planner_extensions.py50982%29–30, 52, 105–119
   sequential_planner_parser.py771284%64–73, 93, 117–120
semantic_kernel/schema
   kernel_json_schema_builder.py71297%45, 155
TOTAL607686186% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1396 1 💤 0 ❌ 0 🔥 15.660s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 31, 2024
Merged via the queue into microsoft:main with commit fbb26b5 May 31, 2024
23 checks passed
@eavanvalkenburg eavanvalkenburg deleted the docs branch May 31, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: add check for Copyright row to pre-commit-config
4 participants