Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tasks.json to use IntegrationTests.csproj #646

Merged

Conversation

lemillermicrosoft
Copy link
Member

@lemillermicrosoft lemillermicrosoft commented Apr 25, 2023

Motivation and Context

Fix the VSCode tasks for integration tests.

Description

This commit changes the tasks.json file to use the IntegrationTests.csproj file instead of the SemanticKernel.IntegrationTests.csproj file. This is because the SemanticKernel project has been renamed to IntegrationTests, and the tasks.json file needs to reflect this change. This affects the test coverage task, which runs the integration tests and generates a lcov report. The commit also updates the cwd option to point to the new project folder.

Contribution Checklist

glahaye
glahaye previously approved these changes Apr 25, 2023
RogerBarreto
RogerBarreto previously approved these changes Apr 25, 2023
@lemillermicrosoft lemillermicrosoft added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. labels Apr 25, 2023
shawncal
shawncal previously approved these changes Apr 25, 2023
      Summary: This commit changes the tasks.json file to use the IntegrationTests.csproj file instead of the SemanticKernel.IntegrationTests.csproj file. This is because the SemanticKernel project has been renamed to IntegrationTests, and the tasks.json file needs to reflect this change. This affects the test coverage task, which runs the integration tests and generates a lcov report. The commit also updates the cwd option to point to the new project folder.
@lemillermicrosoft lemillermicrosoft merged commit 0bf374f into microsoft:main Apr 25, 2023
11 checks passed
dluc pushed a commit that referenced this pull request Apr 29, 2023
### Motivation and Context
Fix the VSCode tasks for integration tests.

### Description
This commit changes the tasks.json file to use the
IntegrationTests.csproj file instead of the
SemanticKernel.IntegrationTests.csproj file. This is because the
SemanticKernel project has been renamed to IntegrationTests, and the
tasks.json file needs to reflect this change. This affects the test
coverage task, which runs the integration tests and generates a lcov
report. The commit also updates the cwd option to point to the new
project folder.
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
Fix the VSCode tasks for integration tests.

### Description
This commit changes the tasks.json file to use the
IntegrationTests.csproj file instead of the
SemanticKernel.IntegrationTests.csproj file. This is because the
SemanticKernel project has been renamed to IntegrationTests, and the
tasks.json file needs to reflect this change. This affects the test
coverage task, which runs the integration tests and generates a lcov
report. The commit also updates the cwd option to point to the new
project folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants