New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jira plugin open api #648
Jira plugin open api #648
Conversation
GetIssue call works via both URl and file defintions change name small refactor rename jira and openAPI skill files; plus minor changes
92ed0cb
to
a47194f
Compare
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Skills/JiraSkill/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
…sons" This reverts commit e60bbf6.
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22_a_OpenApiSkill_AzureKeyVault.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22_b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls see comments about naming and docs
samples/dotnet/kernel-syntax-examples/Example22a_OpenApiSkill_AzureKeyVault.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/kernel-syntax-examples/Example22b_OpenApiSkill_Jira.cs
Outdated
Show resolved
Hide resolved
Curious whether it makes sense to pull the openapi spec from https://developer.atlassian.com/cloud/jira/platform/swagger-v3.v3.json versus including the spec as part of the skill since this create a tight coupling between the version included with the skill and the current version available -- implying I assume that updates must be made here if we want to keep up to date. There's also the risk of a breaking change to Jira's API, which is less likely to happen but does happen, that might render this skill unusable for a customer in production until fix were made. |
Perhaps it could be cached, for efficiency. There is an implicit assumption here that you would always be pulling the latest API as opposed to a specific version so maybe that link above wouldnt work. Maybe https://developer.atlassian.com/cloud/jira/platform/swagger.json is meant to always point to the latest. |
We don't support version 3 in the semantic kernel, so we cant use the latest swagger anyway |
### Motivation and Context Provide an example implementation of connecting the Semantic Kernel to external plugins following the open api schema. ### Description Jira Open API schema usage example Renaming the azure key vault example, so all open api skill examples are grouped together Prevent RestApiOperationRunner.cs from wrapping a json response into a json object.
### Motivation and Context Provide an example implementation of connecting the Semantic Kernel to external plugins following the open api schema. ### Description Jira Open API schema usage example Renaming the azure key vault example, so all open api skill examples are grouped together Prevent RestApiOperationRunner.cs from wrapping a json response into a json object.
### Motivation and Context Provide an example implementation of connecting the Semantic Kernel to external plugins following the open api schema. ### Description Jira Open API schema usage example Renaming the azure key vault example, so all open api skill examples are grouped together Prevent RestApiOperationRunner.cs from wrapping a json response into a json object.
Motivation and Context
Provide an example implementation of connecting the Semantic Kernel to external plugins following the open api schema.
Description
Jira Open API schema usage example
Renaming the azure key vault example, so all open api skill examples are grouped together
Prevent RestApiOperationRunner.cs from wrapping a json response into a json object.
Contribution Checklist
dotnet format