Fix context generation order in chat skill #653
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
added
PR: ready for review
adrianwyatt
approved these changes
Apr 25, 2023
adrianwyatt
added
PR: ready to merge
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context The chat function generates the final prompt by populating it with multiple contexts. Each context is constrained by a token limit except the last one, which is chat history. The chat function will fill up the prompt with chat history to reach the token limit. A bug was discovered that the chat history context was not the last context. ### Description Move chat history to the end of the prompt.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context The chat function generates the final prompt by populating it with multiple contexts. Each context is constrained by a token limit except the last one, which is chat history. The chat function will fill up the prompt with chat history to reach the token limit. A bug was discovered that the chat history context was not the last context. ### Description Move chat history to the end of the prompt.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context The chat function generates the final prompt by populating it with multiple contexts. Each context is constrained by a token limit except the last one, which is chat history. The chat function will fill up the prompt with chat history to reach the token limit. A bug was discovered that the chat history context was not the last context. ### Description Move chat history to the end of the prompt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The chat function generates the final prompt by populating it with multiple contexts. Each context is constrained by a token limit except the last one, which is chat history. The chat function will fill up the prompt with chat history to reach the token limit.
A bug was discovered that the chat history context was not the last context.
Description
Move chat history to the end of the prompt.
Contribution Checklist
dotnet format