Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopilotChat: External skills and planner #659

Merged
merged 31 commits into from Apr 26, 2023

Conversation

adrianwyatt
Copy link
Contributor

@adrianwyatt adrianwyatt commented Apr 26, 2023

Motivation and Context

We want to be able to access external data and run skill sequences as part of CopilotChat. This change enables running skills using a sequential planner with a custom set of skills made available to it.

Description

  • Added a planner factory to CopilotChat and the AcquireExternalInformationAsync function.
  • Added a section to the chat prompt for "Additional Information" that comes from the planner output.
  • Added a JSON extraction method for results that come from OpenAPI skills.
  • Added debug logging of the prompt and completions in the kernel's SKFunction and bumped the SemanticKernel.Service logging to Debug for CopilotChat
  • Added access to the SequentialPlanner's kernel instance.
  • Added planner skills: Klarna, text, time, math, notegen, summarize, topics, and translate.
  • Renamed Utils.csto Utilities.cs

@adrianwyatt adrianwyatt self-assigned this Apr 26, 2023
@adrianwyatt adrianwyatt marked this pull request as draft April 26, 2023 01:39
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 26, 2023
@adrianwyatt adrianwyatt added PR: in progress Under development and/or addressing feedback and removed .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 26, 2023
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 26, 2023
@adrianwyatt adrianwyatt marked this pull request as ready for review April 26, 2023 04:46
@adrianwyatt adrianwyatt added PR: ready for review All feedback addressed, ready for reviews and removed PR: in progress Under development and/or addressing feedback labels Apr 26, 2023
@adrianwyatt adrianwyatt removed the PR: feedback to address Waiting for PR owner to address comments/questions label Apr 26, 2023
@github-actions github-actions bot removed .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 26, 2023
teresaqhoang
teresaqhoang previously approved these changes Apr 26, 2023
@dluc dluc dismissed their stale review April 26, 2023 21:53

The issue with way the planner is integrated will be addressed separately

@adrianwyatt adrianwyatt reopened this Apr 26, 2023
@adrianwyatt adrianwyatt enabled auto-merge (squash) April 26, 2023 22:56
@adrianwyatt adrianwyatt merged commit 8e72a0e into microsoft:main Apr 26, 2023
11 checks passed
dluc pushed a commit that referenced this pull request Apr 29, 2023
### Motivation and Context
We want to be able to access external data and run skill sequences as
part of CopilotChat. This change enables running skills using a
sequential planner with a custom set of skills made available to it.

### Description
- Added a planner factory to CopilotChat and the
AcquireExternalInformationAsync function.
- Added a section to the chat prompt for "Additional Information" that
comes from the planner output.
- Added a JSON extraction method for results that come from OpenAPI
skills.
- Added debug logging of the prompt and completions in the kernel's
SKFunction and bumped the SemanticKernel.Service logging to Debug for
CopilotChat
- Added access to the SequentialPlanner's kernel instance.
- Added planner skills: Klarna, text, time, math, notegen, summarize,
topics, and translate.
- Renamed Utils.csto Utilities.cs
@adrianwyatt adrianwyatt deleted the planner branch May 4, 2023 00:31
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
We want to be able to access external data and run skill sequences as
part of CopilotChat. This change enables running skills using a
sequential planner with a custom set of skills made available to it.

### Description
- Added a planner factory to CopilotChat and the
AcquireExternalInformationAsync function.
- Added a section to the chat prompt for "Additional Information" that
comes from the planner output.
- Added a JSON extraction method for results that come from OpenAPI
skills.
- Added debug logging of the prompt and completions in the kernel's
SKFunction and bumped the SemanticKernel.Service logging to Debug for
CopilotChat
- Added access to the SequentialPlanner's kernel instance.
- Added planner skills: Klarna, text, time, math, notegen, summarize,
topics, and translate.
- Renamed Utils.csto Utilities.cs
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
We want to be able to access external data and run skill sequences as
part of CopilotChat. This change enables running skills using a
sequential planner with a custom set of skills made available to it.

### Description
- Added a planner factory to CopilotChat and the
AcquireExternalInformationAsync function.
- Added a section to the chat prompt for "Additional Information" that
comes from the planner output.
- Added a JSON extraction method for results that come from OpenAPI
skills.
- Added debug logging of the prompt and completions in the kernel's
SKFunction and bumped the SemanticKernel.Service logging to Debug for
CopilotChat
- Added access to the SequentialPlanner's kernel instance.
- Added planner skills: Klarna, text, time, math, notegen, summarize,
topics, and translate.
- Renamed Utils.csto Utilities.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants