Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Fix broken concept samples. Run concept examples as tests. #6660

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

We had many broken concept examples. These samples are also not covered by tests so it's hard to know when things are out of sync.

Description

Fix the Python concept samples, and also cover them with tests so we aren't checking in code that is going to break them.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner June 11, 2024 00:09
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels Jun 11, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jun 11, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai/open_ai/services
   open_ai_chat_completion_base.py2199656%97, 101, 121, 146–150, 174, 178, 182, 201–206, 223–251, 254–265, 280–287, 298–306, 322–329, 350, 358, 364–367, 379–382, 413, 452, 457, 462–467, 471–478, 482–494, 516, 526–537
semantic_kernel/connectors/search_engine
   bing_connector.py443325%38, 47–99
TOTAL615172888% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1434 1 💤 0 ❌ 0 🔥 24.217s ⏱️

Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small note, otherwise looks good!

python/.env.example Outdated Show resolved Hide resolved
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Jun 11, 2024
Merged via the queue into microsoft:main with commit a2720a6 Jun 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants